Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: Ignore workspace name differences while doing header checking #9188

Closed
wants to merge 3 commits into from
Closed

Windows: Ignore workspace name differences while doing header checking #9188

wants to merge 3 commits into from

Conversation

meteorcloudy
Copy link
Member

Fixes #9172

@meteorcloudy meteorcloudy requested review from laszlocsomor and removed request for hlopko and scentini August 16, 2019 10:12
laszlocsomor
laszlocsomor suggested changes Aug 16, 2019
View reviewed changes
Copy link
Contributor

@laszlocsomor laszlocsomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add an integration test?

src/test/java/com/google/devtools/build/lib/rules/cpp/ShowIncludesFilterTest.java Show resolved Hide resolved
@meteorcloudy
Copy link
Member Author

Integration test added, PTAL~

@bazel-io bazel-io closed this in 0b081d8 Aug 19, 2019
@meteorcloudy meteorcloudy mentioned this pull request Feb 19, 2020
Closed
@jayconrod jayconrod mentioned this pull request Oct 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laszlocsomor laszlocsomor laszlocsomor approved these changes

@oquenchil oquenchil Awaiting requested review from oquenchil

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: Bazel cannot share cpp cache between two projects with different workspace name
3 participants
@meteorcloudy @laszlocsomor @googlebot