updated documentation to clarify TLS support #9331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_backend to clarify TLS support
agoulti
reviewed
Sep 5, 2019
| @@ -34,6 +34,8 @@ | |||
| help = | |||
| "Specifies the build event service (BES) backend endpoint as HOST or HOST:PORT. " | |||
| + "Disabled by default." | |||
| + "The supported schemas are grpc and grpcs (grpc with TLS enabled). " | |||
| + "If no schema is provided bazel'll default to grpcs. Specify grpc:// schema to disable TLS." | |||
There was a problem hiding this comment.
This seems to imply that bes_backend should default to grpcs, but from what I've seen it doesn't.
Where's the disconnect?
There was a problem hiding this comment.
It is, starting from version 1.0 (it is not a part of 0.29, I can see that there was a confusion around this, sorry for that). Before 1.0, in order to get this behaviour one have to specify --incompatible_tls_enabled_removed flag.
Starting 1.0 this won't be necessary.
see #8061 for details.
There was a problem hiding this comment.
Ooh, I missed that! Yes, it works with Bazel 1.0 release candidate!
agoulti
approved these changes
Sep 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated documentation to clarify TLS support for --remote_cache, --remote_executor and --bes_backend
Follow-up of #8061