Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent action-cache duplicate suppression #9376

Closed

Conversation

werkt
Copy link
Contributor

@werkt werkt commented Sep 12, 2019

Exceptions that are reused between download futures must not be added to
the suppression of themselves.

Fixes #9362

Exceptions that are reused between download futures must not be added to
the suppression of themselves.

Fixes bazelbuild#9362
Copy link
Contributor

@ishikhman ishikhman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix!

@bazel-io bazel-io closed this in f7a31b3 Sep 23, 2019
@mmorearty
Copy link
Contributor

I think this didn't make it into 1.0.0

dslomov pushed a commit that referenced this pull request Oct 11, 2019
Exceptions that are reused between download futures must not be added to
the suppression of themselves.

Fixes #9362

Closes #9376.

PiperOrigin-RevId: 270658205
dslomov pushed a commit that referenced this pull request Oct 14, 2019
Exceptions that are reused between download futures must not be added to
the suppression of themselves.

Fixes #9362

Closes #9376.

PiperOrigin-RevId: 270658205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

channel close should not throw a RuntimeException
5 participants