Add explicit version minimums for macOS tools #9403
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a follow up to bazelbuild#9371 which helps maintain cache hits across different macOS versions. By default when you compile something on macOS with clang the minimum OS version is set to the current OS version. This means if you have developers on multiple OS versions they may not get cache hits.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #9371
which helps maintain cache hits across different macOS versions. By
default when you compile something on macOS with clang the minimum OS
version is set to the current OS version. This means if you have
developers on multiple OS versions they may not get cache hits.
10.9 was chosen to match rules_apple bazelbuild/rules_apple@86ce425