Parse .netrc for HTTP Basic authentication credentials when BAZELISK_BASE_URL points to protected resource #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@fweikert sorry for pushing that already, but we would need that feature soon and we would like to use an official release in case review pass |
fweikert
reviewed
Jan 24, 2022
| var auth string = "" | ||
| t, err := tryFindNetrcFileCreds(u.Host) | ||
| if err == nil { | ||
| // successfully parsed netrc for given host |
There was a problem hiding this comment.
I'd fail here if the .netrc file exists, but could not be read (for whatever reasons).
There was a problem hiding this comment.
It would also be good to add a log statement regarding whether a .netrc file was read or not
There was a problem hiding this comment.
I'd fail here if the .netrc file exists, but could not be read (for whatever reasons).
.netrc may exist, but may not contain given "Host". In this case we should proceed with normal auth, without a failure, because remote may not have auth at all.
fweikert
reviewed
Jan 24, 2022
fweikert
reviewed
Jan 24, 2022
|
Ping @fweikert |
fweikert
approved these changes
Jan 27, 2022
gcf-merge-on-green bot
referenced
this pull request
in googleapis/gapic-generator-typescript
Jul 22, 2022
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@bazel/bazelisk](https://github.com/bazelbuild/bazelisk) | [`^1.11.0` -> `^1.12.0`](https://renovatebot.com/diffs/npm/@bazel%2fbazelisk/1.11.0/1.12.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>bazelbuild/bazelisk</summary> ### [`v1.12.0`](https://github.com/bazelbuild/bazelisk/releases/tag/v1.12.0) [Compare Source](https://github.com/bazelbuild/bazelisk/compare/v1.11.0...v1.12.0) This release brings new features and fixes to both versions of Bazelisk: Go: - Added support for basic HTTP authentication via a .netrc file ([https://github.com/bazelbuild/bazelisk/pull/292](https://github.com/bazelbuild/bazelisk/pull/292)) - Improved and fixed Apple Silicon support ([https://github.com/bazelbuild/bazelisk/pull/299](https://github.com/bazelbuild/bazelisk/pull/299), [https://github.com/bazelbuild/bazelisk/pull/303](https://github.com/bazelbuild/bazelisk/pull/303)) - Rolling releases are now fetched from GCS instead of GitHub ([https://github.com/bazelbuild/bazelisk/pull/319](https://github.com/bazelbuild/bazelisk/pull/319)) Python: - Added support for Apple Silicon ([https://github.com/bazelbuild/bazelisk/pull/272](https://github.com/bazelbuild/bazelisk/pull/272)) - Implemented verification of downloaded Bazel binaries ([https://github.com/bazelbuild/bazelisk/pull/295](https://github.com/bazelbuild/bazelisk/pull/295)) We'd like to thank our contributors [@​chenrui333](https://github.com/chenrui333), [@​codeman9](https://github.com/codeman9), [@​cpsauer](https://github.com/cpsauer), [@​keith](https://github.com/keith), [@​linzhp](https://github.com/linzhp), [@​Warchant](https://github.com/Warchant) and [@​xinnjie](https://github.com/xinnjie)! </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/gapic-generator-typescript). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xMjIuMSIsInVwZGF0ZWRJblZlciI6IjMyLjEyMi4xIn0=-->
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using .netrc file for getting credentials for Basic HTTP authentication to download bazel from protected resource.
Same as #269 but for Go code.
Fixes #291
Fixes #269
Tested with JFrog Artifactory.