Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add progress display during binary downloads. #511

Merged
merged 1 commit into from
Nov 13, 2023

Conversation

katre
Copy link
Member

@katre katre commented Oct 26, 2023

Example of progress message:

Downloading: 16 MB out of 49 MB (34%)

When using stdout this will be overwritten repeatedly.

@katre
Copy link
Member Author

katre commented Oct 30, 2023

I don't understand the test failures: this appears to be fine in Buildkite on the master branch, but when I run the same test at master locally it fails with the same 404 error.

@meisterT
Copy link
Member

See also #5 for the python counterpart

@katre katre force-pushed the download-progress branch from 0729314 to 2fc96b6 Compare November 10, 2023 17:00
@meteorcloudy meteorcloudy merged commit 3a19bd3 into bazelbuild:master Nov 13, 2023
1 check passed
@katre katre deleted the download-progress branch November 13, 2023 14:21
ti-chi-bot bot referenced this pull request in PingCAP-QE/artifacts Nov 30, 2023
[![Mend Renovate logo
banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [bazelbuild/bazelisk](https://github.com/bazelbuild/bazelisk) |
minor | `v1.18.0` -> `v1.19.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>bazelbuild/bazelisk (bazelbuild/bazelisk)</summary>

###
[`v1.19.0`](https://github.com/bazelbuild/bazelisk/releases/tag/v1.19.0)

[Compare
Source](https://github.com/bazelbuild/bazelisk/compare/v1.18.0...v1.19.0)

Bazelisk v1.19.0 comes with two significant changes:

- `MODULE.bazel` and `REPO.bazel` files are now obeyed
([https://github.com/bazelbuild/bazelisk/pull/503](https://github.com/bazelbuild/bazelisk/pull/503))
- Users will see a progress bar during binary downloads
([https://github.com/bazelbuild/bazelisk/pull/511](https://github.com/bazelbuild/bazelisk/pull/511))

We’d like to thank our amazing contributors
[@&#8203;crncnnr](https://github.com/crncnnr) and
[@&#8203;katre](https://github.com/katre)!

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/PingCAP-QE/artifacts).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants