Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Avoid recompiling regexes #1293

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

perf: Avoid recompiling regexes #1293

wants to merge 1 commit into from

Conversation

dzbarsky
Copy link

@dzbarsky dzbarsky commented Sep 12, 2024 •
edited
Loading

We can compile these once at package scope instead. This is a slight perf improvement on a medium repo.

I removed some unused code while I was here.

@DavidZbarsky-at
Copy link

Example:
image

@dzbarsky
Copy link
Author

dzbarsky commented Dec 9, 2024

@vladmos can you please take a look at this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladmos vladmos Awaiting requested review from vladmos vladmos is a code owner

@pmbethe09 pmbethe09 Awaiting requested review from pmbethe09 pmbethe09 is a code owner

@larsrc-google larsrc-google Awaiting requested review from larsrc-google larsrc-google is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dzbarsky @DavidZbarsky-at