Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set up CI job for Gerrit on Java 10 #325

Closed
davido opened this issue Sep 12, 2018 · 1 comment
Closed

Set up CI job for Gerrit on Java 10 #325

davido opened this issue Sep 12, 2018 · 1 comment

Comments

@davido
Copy link
Contributor

davido commented Sep 12, 2018

Recently CI Job was set up for Gerrit on Java 9 (#322). To avoid regressions, CI Job for Java 10 should also be set up.
@davido davido mentioned this issue Sep 12, 2018
Closed
@davido
Copy link
Contributor Author

davido commented Sep 12, 2018

@philwo One problem for building Gerrit with Java 10 is that no Guice release was made with this ASM change included google/guice#1169. I switched to non shaded Guice version and upgraded ASM in this change that wasn't merged yet: [1]. Would it be possibly to cherry-pick that change on Bazel CI, prior to building Gerrit on java 10 pipeline?

[1] https://gerrit-review.googlesource.com/c/gerrit/+/193832

@davido davido mentioned this issue Sep 25, 2018
Merged
philwo pushed a commit that referenced this issue Jan 14, 2019
@davido @philwo
Actually test Gerrit on ubuntu1804_java11 (#333)
d45e554 
* Actually test Gerrit on ubuntu1804_java10

Closes #325.

* Fix path to Azul Zulu jvm

* Update path to JDK 11
joeleba pushed a commit to joeleba/continuous-integration that referenced this issue Jun 17, 2019
@davido @joeleba
Actually test Gerrit on ubuntu1804_java11 (bazelbuild#333)
7bce8bd 
* Actually test Gerrit on ubuntu1804_java10

Closes bazelbuild#325.

* Fix path to Azul Zulu jvm

* Update path to JDK 11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@davido