Expose output base path as OUTPUT_BASE env var #1331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meisterT
approved these changes
Feb 10, 2022
fweikert
added a commit
to bazel-contrib/vscode-bazel
that referenced
this pull request
Aug 2, 2022
This project is in a weird state right now: It cannot be built with Bazel, yet we use Bazel CI in order to run some npm commands during presubmit. Eventually we should make it buildable and testable with Bazel. This commit fixes #269, which was broken by bazelbuild/continuous-integration#1331 Some context: Our CI infra expects all projects to be buildable with Bazel, i.e. there must be a WORKSPACE file and at least one BUILD file. This project did not meet this requirement, but we still wanted to run it on CI. Someone came up with a workaround: Let's create dummy WORKSPACE and BUILD files during setup ("shell_commands"). However, this stopped working because bazelbuild/continuous-integration#1331 changed the CI infra to run bazel info before executing the shell commands which then failed because there was no Bazel workspace yet.
fweikert
added a commit
to bazel-contrib/vscode-bazel
that referenced
this pull request
Aug 2, 2022
This commit fixes #269, which was caused by bazelbuild/continuous-integration#1331 Some context: Our CI infra expects all projects to be buildable with Bazel, i.e. there must be a WORKSPACE file and at least one BUILD ile. This project did not meet this requirement, but we still wanted to have it on CI to run some npm commands. Someone came up with a workaround: Let's create dummy WORKSPACE and BUILD files during setup ("shell_commands"). However, this stopped working because bazelbuild/continuous-integration#1331 changed the CI infra to run bazel info before executing the shell commands which then failed because there was no Bazel workspace yet. Eventually we should make this project buildable and testable with Bazel.
fweikert
added a commit
to bazel-contrib/vscode-bazel
that referenced
this pull request
Aug 2, 2022
This commit fixes #269, which was caused by bazelbuild/continuous-integration#1331 Some context: Our CI infra expects all projects to be buildable with Bazel, i.e. there must be a WORKSPACE file and at least one BUILD file. This project did not meet this requirement, but we still wanted to have it on CI to run some npm commands. Someone came up with a workaround: Let's create dummy WORKSPACE and BUILD files during setup ("shell_commands"). However, this stopped working because bazelbuild/continuous-integration#1331 changed the CI infra to run `bazel info` before executing the shell commands, which then failed because there was no Bazel workspace yet. Eventually we should make this project buildable and testable with Bazel.
coeuvre
pushed a commit
to bazel-contrib/vscode-bazel
that referenced
this pull request
Aug 2, 2022
This commit fixes #269, which was caused by bazelbuild/continuous-integration#1331 Some context: Our CI infra expects all projects to be buildable with Bazel, i.e. there must be a WORKSPACE file and at least one BUILD file. This project did not meet this requirement, but we still wanted to have it on CI to run some npm commands. Someone came up with a workaround: Let's create dummy WORKSPACE and BUILD files during setup ("shell_commands"). However, this stopped working because bazelbuild/continuous-integration#1331 changed the CI infra to run `bazel info` before executing the shell commands, which then failed because there was no Bazel workspace yet. Eventually we should make this project buildable and testable with Bazel.
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this pull request
Dec 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we can depend on $OUTPUT_BASE in
shell_commandsorbatch_commands