Build java_tools for darwin arm64 #1511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fweikert
approved these changes
Dec 8, 2022
The cpp only toolchain can't compile universal binaries for darwin
hvadehra
changed the title
meteorcloudy
approved these changes
Dec 13, 2022
|
Why did you revert to macos? It's not using the M1 workers anymore. |
|
My understanding is that there will be one java_tools archive for macOS, and it works both on x86 and arm64 platforms? @hvadehra Is that correct? |
|
Yes, we are cross-compiling to both architectures and merging into a single binary. And it doesn't matter which host we use as long as xcode version >= 12.2. |
fmeum
pushed a commit
to fmeum/continuous-integration
that referenced
this pull request
Dec 10, 2023
java_tools for darwin will be built as a fat universal binary after bazelbuild/bazel#16960 so it needs to use the osx toolchain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java_tools for darwin will be built as a fat universal binary after bazelbuild/bazel#16960 so it needs to use the osx toolchain.