Implement an example maven project #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| java_library( | ||
| name = "java-maven-lib", | ||
| srcs = glob(["src/main/**/myproject/*.java"]), |
There was a problem hiding this comment.
Prefer non-recursive globs (or no globs at all when there's just one file).
|
LGTM. Jenkins, test this please. |
|
We do not have jenkins presubmit for this project. The reason? there is no separate configure step, we should make this project testable with only |
|
LGTM too, this project won't even run on ci.bazel.io because we only test the tutorial. |
|
Manually built & tested, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an example Java project that uses Maven for getting dependencies.
bazelbuild/bazel#1410
I'm in the midst of writing a Skylark rule for maven_jar and maven_server,
but while that is in progress, here's the example project that I'm testing with.