Skip to content

Commit

Permalink
Stop including the walltime field in the execution log.
Browse files Browse the repository at this point in the history
We now unconditionally emit the full spawn metrics, which already include the wall time; the extra field is wasteful and potentially confusing.

Progress on bazelbuild/bazel#18643.

PiperOrigin-RevId: 582282615
  • Loading branch information
tjgq authored and copybara-github committed Nov 14, 2023
1 parent b7e97fd commit ab4d2a1
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions third_party/bazel/src/main/protobuf/spawn.proto
Original file line number Diff line number Diff line change
Expand Up @@ -173,10 +173,6 @@ message SpawnExec {
// Was the Spawn result allowed to be cached remotely.
bool remote_cacheable = 16;

// The wall time it took to execute the Spawn. This is only the time spent in
// the subprocess, not including the time doing setup and teardown.
google.protobuf.Duration walltime = 17;

// Canonical label of the target that emitted this spawn, may not always be
// set.
string target_label = 18;
Expand All @@ -189,5 +185,5 @@ message SpawnExec {
// Timing, size and memory statistics.
SpawnMetrics metrics = 20;

reserved 9;
reserved 9, 17;
}

0 comments on commit ab4d2a1

Please sign in to comment.