Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bazel incompatible flags #529

Closed
laurentlb opened this issue Mar 6, 2019 · 4 comments · Fixed by #834
Closed

Bazel incompatible flags #529

laurentlb opened this issue Mar 6, 2019 · 4 comments · Fixed by #834
Assignees
@jin
Labels
topic: bazel Bazel integration (external repositories, aspects, flags, etc)

Comments

@laurentlb
Copy link

As mentioned in #517, we run test the repository on Bazel CI. To avoid any breakage, we'd like to make sure issues are fixed in advance. Based on our latest CI run (https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/28#0ce981a8-efbe-481c-8105-72ee6098a934), migration is needed for the following flags:

  • --incompatible_depset_is_not_iterable
  • --incompatible_depset_union
  • --incompatible_disable_deprecated_attr_params
  • --incompatible_disable_legacy_cc_provider
  • --incompatible_disallow_legacy_py_provider
  • --incompatible_merge_genfiles_directory
  • --incompatible_new_actions_api
  • --incompatible_use_toolchain_providers_in_java_common

In particular, I plan to flip --incompatible_merge_genfiles_directory very soon.
Let me know if you need any help.
@jvoung
Copy link

jvoung commented Mar 11, 2019

There's some update in the latest commits for --incompatible_merge_genfiles_directory:
9251dca#diff-8825cb09855ccccac6d20911755d4284L45

--incompatible_disable_legacy_cc_provider should be #527

When would --incompatible_disallow_legacy_py_provider be scheduled for a flip? It sounds like it was introduced in 0.23 (bazelbuild/bazel#7298)

Some updates for --incompatible_depset_union, --incompatible_new_actions_api as well:
9251dca#diff-ce84cc6cc21958f1b5bc7f65e7555c00L34

@brandjon
Copy link
Member

I sent #538 for --incompatible_disallow_legacy_py_provider. It was introduced in Bazel 0.23 and is scheduled to be flipped in 0.25.

@brendandouglas brendandouglas mentioned this issue Apr 8, 2019
Closed
@laurentlb
Copy link
Author

Thanks.

There's still some work to do. Migration is needed for --incompatible_depset_is_not_iterable and --incompatible_disable_deprecated_attr_params.

https://buildkite.com/bazel/bazelisk-plus-incompatible-flags/builds/88#c2fb4d3f-73ab-4881-ab43-85eaf8af2e7d

@jin jin added the topic: bazel Bazel integration (external repositories, aspects, flags, etc) label May 1, 2019
@laurentlb
Copy link
Author

@jin Do you want to look at --incompatible_depset_is_not_iterable?

For --incompatible_disable_deprecated_attr_params, we'll need to update the dependency on protobuf.

@jin jin self-assigned this May 14, 2019
@laurentlb laurentlb mentioned this issue May 17, 2019
Closed
ghost pushed a commit that referenced this issue May 17, 2019
@copybara-github
Add explicit depset to list conversions
1b120d4 
Implicit conversions will be forbidden with upcoming
incompatible_depset_is_not_iterable change in Bazel.

Progress towards #529
Closes #816

PiperOrigin-RevId: 248731241
ghost pushed a commit that referenced this issue May 17, 2019
@copybara-github
Add explicit depset to list conversions
9430b15 
Implicit conversions will be forbidden with upcoming
incompatible_depset_is_not_iterable change in Bazel.

Progress towards #529
Closes #816

PiperOrigin-RevId: 248731241
ghost pushed a commit that referenced this issue May 17, 2019
@copybara-github
Add explicit depset to list conversions
9e11bb3 
Implicit conversions will be forbidden with upcoming
incompatible_depset_is_not_iterable change in Bazel.

Progress towards #529
Closes #816

PiperOrigin-RevId: 248738486
ghost pushed a commit that referenced this issue May 22, 2019
@jin @copybara-github
Address Bazel's --incompatible_depset_is_not_iterable in build_defs.bzl
89e873c 
Fixes #529

With this change, the Bazel build is compatible with all flags listed in #529 (comment)

$ bazel build //ijwb:ijwb_bazel_zip --define=ij_product=intellij-latest --incompatible_depset_is_not_iterable --incompatible_depset_is_not_iterable --incompatible_depset_union --incompatible_disable_deprecated_attr_params --incompatible_disable_legacy_cc_provider --incompatible_disallow_legacy_py_provider --incompatible_merge_genfiles_directory --incompatible_new_actions_api --incompatible_use_toolchain_providers_in_java_common
INFO: Build option --define has changed, discarding analysis cache.
WARNING: /usr/local/google/home/jingwen/code/intellij/java/BUILD:177:1: in java_import rule //java:jdk_tools_jar: target '//java:jdk_tools_jar' depends on deprecated target '@local_jdk//:langtools': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see bazelbuild/bazel#5594)
INFO: Analyzed target //ijwb:ijwb_bazel_zip (9 packages loaded, 2036 targets configured).
INFO: Found 1 target...
Target //ijwb:ijwb_bazel_zip up-to-date:
  bazel-bin/ijwb/ijwb_bazel.zip
PiperOrigin-RevId: 249526071
@ghost ghost mentioned this issue May 22, 2019
Merged
ghost pushed a commit that referenced this issue May 23, 2019
@jin @copybara-github
Address Bazel's --incompatible_depset_is_not_iterable in build_defs.bzl
0b14877 
Fixes #529

With this change, the Bazel build is compatible with all flags listed in #529 (comment)

$ bazel build //ijwb:ijwb_bazel_zip --define=ij_product=intellij-latest --incompatible_depset_is_not_iterable --incompatible_depset_is_not_iterable --incompatible_depset_union --incompatible_disable_deprecated_attr_params --incompatible_disable_legacy_cc_provider --incompatible_disallow_legacy_py_provider --incompatible_merge_genfiles_directory --incompatible_new_actions_api --incompatible_use_toolchain_providers_in_java_common
INFO: Build option --define has changed, discarding analysis cache.
WARNING: /usr/local/google/home/jingwen/code/intellij/java/BUILD:177:1: in java_import rule //java:jdk_tools_jar: target '//java:jdk_tools_jar' depends on deprecated target '@local_jdk//:langtools': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see bazelbuild/bazel#5594)
INFO: Analyzed target //ijwb:ijwb_bazel_zip (9 packages loaded, 2036 targets configured).
INFO: Found 1 target...
Target //ijwb:ijwb_bazel_zip up-to-date:
  bazel-bin/ijwb/ijwb_bazel.zip
PiperOrigin-RevId: 249526071
ghost pushed a commit that referenced this issue May 23, 2019
@jin @copybara-github
Address Bazel's --incompatible_depset_is_not_iterable in build_defs.bzl
cefb9ea 
Fixes #529

With this change, the Bazel build is compatible with all flags listed in #529 (comment)

$ bazel build //ijwb:ijwb_bazel_zip --define=ij_product=intellij-latest --incompatible_depset_is_not_iterable --incompatible_depset_is_not_iterable --incompatible_depset_union --incompatible_disable_deprecated_attr_params --incompatible_disable_legacy_cc_provider --incompatible_disallow_legacy_py_provider --incompatible_merge_genfiles_directory --incompatible_new_actions_api --incompatible_use_toolchain_providers_in_java_common
INFO: Build option --define has changed, discarding analysis cache.
WARNING: /usr/local/google/home/jingwen/code/intellij/java/BUILD:177:1: in java_import rule //java:jdk_tools_jar: target '//java:jdk_tools_jar' depends on deprecated target '@local_jdk//:langtools': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see bazelbuild/bazel#5594)
INFO: Analyzed target //ijwb:ijwb_bazel_zip (9 packages loaded, 2036 targets configured).
INFO: Found 1 target...
Target //ijwb:ijwb_bazel_zip up-to-date:
  bazel-bin/ijwb/ijwb_bazel.zip
PiperOrigin-RevId: 249659976
@ghost ghost closed this as completed in #834 May 23, 2019
krlvi pushed a commit to krlvi/intellij that referenced this issue Sep 20, 2019
@krlvi
Add explicit depset to list conversions
2e36a0d 
Implicit conversions will be forbidden with upcoming
incompatible_depset_is_not_iterable change in Bazel.

Progress towards bazelbuild#529
Closes bazelbuild#816

PiperOrigin-RevId: 248738486
krlvi pushed a commit to krlvi/intellij that referenced this issue Sep 20, 2019
@jin @krlvi
Address Bazel's --incompatible_depset_is_not_iterable in build_defs.bzl
af53cce 
Fixes bazelbuild#529

With this change, the Bazel build is compatible with all flags listed in bazelbuild#529 (comment)

$ bazel build //ijwb:ijwb_bazel_zip --define=ij_product=intellij-latest --incompatible_depset_is_not_iterable --incompatible_depset_is_not_iterable --incompatible_depset_union --incompatible_disable_deprecated_attr_params --incompatible_disable_legacy_cc_provider --incompatible_disallow_legacy_py_provider --incompatible_merge_genfiles_directory --incompatible_new_actions_api --incompatible_use_toolchain_providers_in_java_common
INFO: Build option --define has changed, discarding analysis cache.
WARNING: /usr/local/google/home/jingwen/code/intellij/java/BUILD:177:1: in java_import rule //java:jdk_tools_jar: target '//java:jdk_tools_jar' depends on deprecated target '@local_jdk//:langtools': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see bazelbuild/bazel#5594)
INFO: Analyzed target //ijwb:ijwb_bazel_zip (9 packages loaded, 2036 targets configured).
INFO: Found 1 target...
Target //ijwb:ijwb_bazel_zip up-to-date:
  bazel-bin/ijwb/ijwb_bazel.zip
PiperOrigin-RevId: 249659976
aradchykov pushed a commit to aradchykov/intellij that referenced this issue Oct 6, 2019
@aradchykov
Add explicit depset to list conversions
ceedd76 
Implicit conversions will be forbidden with upcoming
incompatible_depset_is_not_iterable change in Bazel.

Progress towards bazelbuild#529
Closes bazelbuild#816

PiperOrigin-RevId: 248738486
aradchykov pushed a commit to aradchykov/intellij that referenced this issue Oct 6, 2019
@jin @aradchykov
Address Bazel's --incompatible_depset_is_not_iterable in build_defs.bzl
4b3dd62 
Fixes bazelbuild#529

With this change, the Bazel build is compatible with all flags listed in bazelbuild#529 (comment)

$ bazel build //ijwb:ijwb_bazel_zip --define=ij_product=intellij-latest --incompatible_depset_is_not_iterable --incompatible_depset_is_not_iterable --incompatible_depset_union --incompatible_disable_deprecated_attr_params --incompatible_disable_legacy_cc_provider --incompatible_disallow_legacy_py_provider --incompatible_merge_genfiles_directory --incompatible_new_actions_api --incompatible_use_toolchain_providers_in_java_common
INFO: Build option --define has changed, discarding analysis cache.
WARNING: /usr/local/google/home/jingwen/code/intellij/java/BUILD:177:1: in java_import rule //java:jdk_tools_jar: target '//java:jdk_tools_jar' depends on deprecated target '@local_jdk//:langtools': Don't depend on targets in the JDK workspace; use @bazel_tools//tools/jdk:current_java_runtime instead (see bazelbuild/bazel#5594)
INFO: Analyzed target //ijwb:ijwb_bazel_zip (9 packages loaded, 2036 targets configured).
INFO: Found 1 target...
Target //ijwb:ijwb_bazel_zip up-to-date:
  bazel-bin/ijwb/ijwb_bazel.zip
PiperOrigin-RevId: 249659976
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jin jin

Labels
topic: bazel Bazel integration (external repositories, aspects, flags, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address Bazel's --incompatible_depset_is_not_iterable in build_defs.bzl bazelbuild/intellij
4 participants
@jin @laurentlb @brandjon @jvoung