Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build unnecessary jars. #1786

Closed
wants to merge 1 commit into from
Closed

Conversation

uri-canva
Copy link
Contributor

@uri-canva uri-canva commented Apr 22, 2020

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #1785

Description of this change

Don't build the class jar if source jars are available, as we can use that in conjunction with the interface jar to index the code instead.

@uri-canva
Copy link
Contributor Author

ping @vsiva @chaoren @brendandouglas

@uri-canva uri-canva closed this Jul 31, 2020
@uri-canva uri-canva deleted the sync branch July 31, 2020 02:49
@uri-canva uri-canva restored the sync branch August 4, 2020 23:02
@uri-canva uri-canva reopened this Aug 4, 2020
@uri-canva
Copy link
Contributor Author

ping @vsiva @chaoren @brendandouglas

@uri-canva
Copy link
Contributor Author

@AlexeyGy A long time has passed since the PR was put up, so maybe it's not even the same people working on the project anymore, is there a way to ping current reviewers?

@uri-canva uri-canva closed this Jun 12, 2022
@uri-canva uri-canva deleted the sync branch June 12, 2022 03:19
@nkoroste
Copy link
Contributor

nkoroste commented Oct 3, 2023

I think this might still be useful should we reopen it?

@uri-canva
Copy link
Contributor Author

Feel free to open a new PR with the code, I signed the CLA before, but we're not using this patch anymore.

@nkoroste
Copy link
Contributor

Happy to. Curious, why aren't you using the patch though? did you find it not helpful anymore?

@nkoroste nkoroste mentioned this pull request Oct 20, 2023
3 tasks
@uri-canva
Copy link
Contributor Author

We've changed our workflows so the plugin is less integrated in them, that way issues with the plugin are less impactful, and we don't need to worry or work around them as much anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants