Stringify "@//foo:bar" labels for instrumentation test targets #4529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasCJY
requested review from
mai93,
jastice,
tpasternak and
estebandlc
as code owners
sgowroji
added
product: IntelliJ
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
Based on: #4529 PiperOrigin-RevId: 513090325
copybara-service bot
pushed a commit
that referenced
this pull request
Mar 1, 2023
Based on: #4529 PiperOrigin-RevId: 513280259
|
Close PR as it's fixed in #4530 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
I have filed an issue about this change and discussed potential changes with the maintainers.
see
@//foo:barstringifies to//foo:barbazel#15916I have received the approval from the maintainers to make this change.
This is not a stylistic, refactoring, or cleanup change.
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Change
Follow up patch for 41d1964
we also need to stringify target label for instrumentation test targets as well. Otherwise, test button for android_instrumentation_test rule will not work