Perform query lookup for the specific target in case it's not part of the synced data

[rogerhu]

Related to: #4546

Checklist

• I have filed an issue about this change and discussed potential changes with the maintainers.
• I have received the approval from the maintainers to make this change.
• This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #4546

Description of this change

If the kind cannot be determined from the sync process, we invoke the Bazel process to query the kind being specified. There are similar classes that do similar things but this code gets invoked asynchronously as a Future and we only want to query the target specifically.

[cheister]

+1

[mai93]

IIUC Finder interfaces like TargetFinder and SourceToTargetFinder must be fast, that's why they are implemented to just lookup the TargetMap. Also I think there is a pattern to avoid running bazel commands, like bazel query in this case, implicitly like this to not affect the performance.

[rogerhu]

IIUC Finder interfaces like TargetFinder and SourceToTargetFinder must be fast, that's why they are implemented to just lookup the TargetMap. Also I think there is a pattern to avoid running bazel commands, like bazel query in this case, implicitly like this to not affect the performance.

If that's a requirement (or is it?), would removing the manual tag (

intellij/base/src/com/google/idea/blaze/base/dependencies/BlazeQueryDirectoryToTargetProvider.java

Line 72 in 94b6618

return String.format("attr(\"tags\", \"^((?!manual).)*$\", %s)", targets);

) as part of generating the TargetMap be a better alternative?

[mai93]

@rogerhu can we close this PR as #5085 is merged now?

[rogerhu]

Yes!