Collect generated proto go sources from OutputGroup #459
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaoren
reviewed
Nov 29, 2018
| return None | ||
| go_proto_info = target.aspect_proto_go_api_info | ||
| files = getattr(go_proto_info, "files_to_build", []) | ||
| files = [] |
There was a problem hiding this comment.
This is not necessary, variables can be declared in the if scope, and still be used outside of the scope.
| go_proto_info = target.aspect_proto_go_api_info | ||
| files += getattr(go_proto_info, "files_to_build", []) | ||
| if hasattr(target[OutputGroupInfo], "go_generated_srcs"): | ||
| files += target[OutputGroupInfo].go_generated_srcs.to_list() | ||
| return [f for f in files if f.basename.endswith(".pb.go")] |
There was a problem hiding this comment.
This will return an empty [] if neither if statement matches.
|
Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rules_go now exposes proto generated srcs via the
go_generated_srcsOutputGroup as of 45e26a2e. This PR updates the IntelliJ aspect to collect those sources.Resolves #194