Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(clion): Add working directory to CLion Run configurations #4933

Closed

Conversation

blorente
Copy link
Collaborator

@blorente blorente commented Jun 1, 2023

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: N/A

Description of this change

In CMake CLion, one has the option of setting a working directory under which the binary will be run. This is useful for debugging single binaries (i.e. they need no runfiles) under different contexts.

This PR adds some of that capability to the Bazel plugin by creating a setting for run configurations, and adding it to the Cidr debug process handlers.

Limitations:

  • For now, this only applies to CLion debugging configurations. Other debuggers will have to be modified to use the setting, as well as non-debug configurations.
  • Previously, we defaulted to the runfiles dir as the pwd if there was one. The explicit working dir has precedence over it now.
Screenshot 2023-06-01 at 10 18 53

@tpasternak
Copy link
Collaborator

My only concern is that there is a difference between debug and run result now. I know it's mentioned in checkbox's label, but still it may cause some annoyance

@sgowroji sgowroji added the awaiting-review Awaiting review from Bazel team on PRs label Jun 5, 2023
@shs96c
Copy link

shs96c commented Aug 15, 2024

@sgowroji or @tpasternak, is there anything that can be done to help push this forwards?

@ujohnny ujohnny self-assigned this Aug 16, 2024
@ujohnny
Copy link
Collaborator

ujohnny commented Aug 16, 2024

I'll take a look at this one next week

@tpasternak
Copy link
Collaborator

@shs96c sorry for the delay. Would it be possible for you to just rebase the PR? I think it's ok.

@shs96c
Copy link

shs96c commented Aug 30, 2024

@tpasternak, @blorente has left our team, and rather than bother him I've opened #6698 as a fresh version of this PR.

@tpasternak tpasternak closed this Sep 2, 2024
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang: c++ C++ rules integration product: CLion CLion plugin
Projects
Development

Successfully merging this pull request may close these issues.

5 participants