Use correct filter for IntelliJ SDK architecture selector #5073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgowroji
added
product: IntelliJ
IntelliJ SDK uses amd64 unlike x86_64 os.arch JVM property on macOS. This fixes bazelbuild#5058 which makes impossible running intellij with bazel plugin on intel mac.
ujohnny
force-pushed
the
enovozhilov/bazel-intellij-plugin-intel-mac
branch
from
8fb869d
to
1fc16df
Compare
tpasternak
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number: #5058
Description of this change
IntelliJ SDK uses amd64 unlike x86_64 os.arch JVM property on macOS. This fixes #5058 which makes impossible running intellij with bazel plugin on intel mac. There is a utility class available in IntelliJ SDK which can be used for CPU architecture (actually JVM) detection.