Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Select source roots for library jars that have interim folders like `… #5117

Merged
merged 14 commits into from
Aug 2, 2023
Merged

Select source roots for library jars that have interim folders like `… #5117

merged 14 commits into from
Aug 2, 2023

Commits on Jul 17, 2023

  1. Select source roots for library jars that have interim folders like `… 

    …/src/...`. IJ UI logic is reused and suggested candidate selected if and only if there is one candidate exists.
    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    5fbd5cf View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2023

  1. Add registry value to conditionally import all of the source dirs fro… 

    …m a single source jar.
    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    563474f View commit details
    Browse the repository at this point in the history

  2. Registry key definition

    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    75b79a2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into non-default-source-roots-detection

    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    c101401 View commit details
    Browse the repository at this point in the history

Commits on Jul 26, 2023

  1. Merge remote-tracking branch 'origin/master' into non-default-source-… 

    …roots-detection
    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d011260 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. Merge branch 'master' into non-default-source-roots-detection

    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    587d7e2 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2023

  1. Merge branch 'master' into non-default-source-roots-detection

    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 29, 2023
    Configuration menu
    Copy the full SHA
    ca43fce View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. Addressed PR comments: 

    1. Moved some jar class/source related logic to BazelJarLibrary class from `base` module LibraryModifier.
2. Added proper progress indicator.
3. Applied registry key description edits suggestions.
    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    af4d35b View commit details
    Browse the repository at this point in the history

  2. Cleanup unused imports

    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    f2eb19a View commit details
    Browse the repository at this point in the history

  3. Created default impls to not upset existing LibrarySourceProviders ou… 

    …t there
    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    fa4684e View commit details
    Browse the repository at this point in the history

  4. Proper message for progress task

    @dkashyn-sfdc
    dkashyn-sfdc committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    b846629 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2023

  1. Merge remote-tracking branch 'origin/master' into non-default-source-… 

    …roots-detection
    @dkashyn-sfdc
    dkashyn-sfdc committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    47c7432 View commit details
    Browse the repository at this point in the history

  2. Review comments

    @dkashyn-sfdc
    dkashyn-sfdc committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    c50a400 View commit details
    Browse the repository at this point in the history

  3. Reverted excessive formatting changes and empty lines.

    @dkashyn-sfdc
    dkashyn-sfdc committed Aug 2, 2023
    Configuration menu
    Copy the full SHA
    f7d0e7c View commit details