Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle null function returned from CLion code #5248

Merged

Conversation

ujohnny
Copy link
Collaborator

@ujohnny ujohnny commented Aug 15, 2023

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #5247.

Description of this change

Check object returned from CLion SDK for null.

@github-actions github-actions bot added the awaiting-review Awaiting review from Bazel team on PRs label Aug 15, 2023
method is declared as @nullable in CLion SDK
though sdkcompat ignores this hint. fixes bazelbuild#5247.
@ujohnny ujohnny force-pushed the enovozhilov/fix-npe-cmake-notification branch from d5fa54c to 89b1228 Compare August 15, 2023 14:21
@sgowroji sgowroji added the product: CLion CLion plugin label Aug 16, 2023
@tpasternak tpasternak merged commit 916324c into bazelbuild:master Aug 31, 2023
1 check passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin
Projects
Development

Successfully merging this pull request may close these issues.

3 participants