Make QuerySummary a member variable in BlazeQueryParser.
#5388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
added
the
copybara-exported
copybara-service
bot
force-pushed
the
test_568487464
branch
2 times, most recently
from
11bf3fe
to
f0e5e04
Compare
copybara-service
bot
force-pushed
the
test_568487464
branch
from
f0e5e04
to
0457c65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
QuerySummarya member variable inBlazeQueryParser.The parser is already single use, to making the summary a member simplifies it's implementation avoiding the need to pass the query around to all methods. This also unlocks further code improvements required to implemet c++ support.
Also add a simple factory class to ensure that the single use semantics of the parser are clear for all callers.