Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Force JarCache to be on on JarCache tests #5530

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

blorente
Copy link
Collaborator

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Discovered while trying to set up CI for our internal mirror of the plugin.

Description of this change

The combination of running these tests from macOS in bazel doesn't seem to work for these tests, because the BlazeJavaUserSettings default to useJarCache=false when we're not running with Blaze.

To solve it, we:

  • Force BlazeJavaUserSettings.useJarCache to true, because that's what we're testing.
  • Make the tests believe that they are running under Bazel, because JarCaches are only allowed in Mac if they are under Bazel (and not Blaze).

@github-actions github-actions bot added product: IntelliJ IntelliJ plugin awaiting-review Awaiting review from Bazel team on PRs labels Oct 24, 2023
@mai93 mai93 merged commit 206c3d3 into bazelbuild:master Oct 24, 2023
8 checks passed
@mai93 mai93 removed the awaiting-review Awaiting review from Bazel team on PRs label Oct 24, 2023
blorente pushed a commit to blorente/intellij that referenced this pull request Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: IntelliJ IntelliJ plugin
Projects
Development

Successfully merging this pull request may close these issues.

2 participants