Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OLDEST_SUPPORTED_VERSION to 0.23.0+ #610

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,9 @@
/** Verifies that the available Bazel version is supported by this plugin. */
public class BazelVersionChecker implements BuildSystemVersionChecker {

// version 0.18 introduced a backwards-incompatible change to the depset API
private static final BazelVersion OLDEST_SUPPORTED_VERSION = new BazelVersion(0, 18, 0);
// version 0.23 introduced a backwards-incompatible change to the Py struct
// providers. See: https://github.com/bazelbuild/bazel/issues/7298
private static final BazelVersion OLDEST_SUPPORTED_VERSION = new BazelVersion(0, 23, 0);

@Override
public boolean versionSupported(BlazeContext context, BlazeVersionData version) {
Expand Down