Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI build on Windows #6494

Merged
merged 1 commit into from
Jun 20, 2024
Merged

Conversation

tpasternak
Copy link
Collaborator

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: <please reference the issue number or url here>

Description of this change

@tpasternak tpasternak force-pushed the ci-build-on-windows branch 2 times, most recently from 1361336 to 5417474 Compare June 20, 2024 15:59
@tpasternak tpasternak marked this pull request as ready for review June 20, 2024 16:27
@@ -76,3 +76,12 @@ tasks:
- //:clwb_tests
soft_fail:
- exit_status: 1
CLion-OSS-under-dev:
name: CLion OSS Under Development
platform: ubuntu1804
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be windows?

@@ -76,4 +76,13 @@ tasks:
- //:ijwb_ce_tests
soft_fail:
- exit_status: 1
IntelliJ-CE-OSS-under-dev:
name: IntelliJ CE OSS Under Development
platform: ubuntu1804
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also this one

@mai93
Copy link
Collaborator

mai93 commented Jun 20, 2024

is there a reason we are only adding builds on windows and not also tests?

@tpasternak
Copy link
Collaborator Author

a few tests fail on windows, but having build running there is still better than nothing

@mai93 mai93 merged commit 6a812a1 into bazelbuild:master Jun 20, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants