Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes after sync freeze on MacOS #6562

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

LeFrosch
Copy link
Collaborator

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number:

Description of this change

CLion freezes every time after sync because the XcodeCompilerSettings are resolved under read lock.

I think we can drop the read lock for the entire workspace update since as far as I can tell nothing actually requires a read lock. And the actual update of the workspace is performed under write lock.

Or we could just move the compiler settings resolution before the read lock is taken. But dropping the read lock might prevent freezes in future.

@LeFrosch LeFrosch marked this pull request as ready for review July 10, 2024 10:36
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Jul 10, 2024
@LeFrosch LeFrosch requested a review from ujohnny July 10, 2024 10:37
@ujohnny
Copy link
Collaborator

ujohnny commented Jul 11, 2024

I see that a while ago RA was pushed down in a045eab, but I'm not sure what part of update actually requires RA. Is it so that no runtime warnings for missing RA are reported? It could be that OCWorkspace.getConfigurations requires it, but it's not mentioned in the doc.

Copy link
Collaborator

@ujohnny ujohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The purpose of removed RA is unclear to me and it's not required by the code called.

@ujohnny ujohnny merged commit 933664c into bazelbuild:master Jul 11, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Jul 11, 2024
@LeFrosch LeFrosch deleted the Daniel.Brauner/mac-freeze-fix branch September 19, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants