-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invoke bazel build during sync using --target_pattern_fi… #6595
Invoke bazel build during sync using --target_pattern_fi… #6595
Conversation
…le flag Description JIRA: SNOW-1482917 Use --target_pattern_file flag during sync instead of passing list of targets to avoid large command line errors in the same spirit as bazelbuild#6537. Testing
@sfc-gh-mgalindo it's still in draft mode, would you like us to review it? |
@tpasternak yes, please review. Marked it as ready for review now |
private static @NotNull Path prepareTargetPatternFile(List<? extends TargetExpression> targets) throws BuildException { | ||
Path targetPatternFile = null; | ||
try { | ||
targetPatternFile = Files.createTempFile("targets-", ""); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we create the file in a directory under the project similar to here: https://github.com/tpasternak/bazel-intellij/blob/769b653fa5ca7a71f92c44f897584e1d3b2011de/base/src/com/google/idea/blaze/base/dependencies/BlazeQuerySourceToTargetProvider.java#L229?
@sfc-gh-mgalindo Thank you for the contribution! I agree with Mai, could you please put the temporary in the same directory as the previous one? Apart from that LGTM |
Done. |
Thanks, please only fix the compilation errors and we'll merge it |
Thanks! |
|
Use --target_pattern_file flag during sync instead of passing list of targets to avoid large command line errors in the same spirit as #6537.