Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Buildifier Binary #6625

Merged

Conversation

LeFrosch
Copy link
Collaborator

@LeFrosch LeFrosch commented Aug 8, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: #6626

Description of this change

Adds a new notification with a "download" button. Buildifier is downloaded from the GitHub releases.

@LeFrosch LeFrosch force-pushed the Daniel.Brauner/download-buildifier branch 2 times, most recently from b7330d1 to 39f5047 Compare August 8, 2024 13:52
@LeFrosch LeFrosch marked this pull request as ready for review August 8, 2024 14:36
@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Aug 8, 2024
@LeFrosch LeFrosch force-pushed the Daniel.Brauner/download-buildifier branch from 2568a5c to 68c4dc6 Compare October 9, 2024 15:32
@LeFrosch
Copy link
Collaborator Author

LeFrosch commented Oct 9, 2024

Rebased master, no conflicts and still seems to be working as expected.

@LeFrosch LeFrosch merged commit 5ac22de into bazelbuild:master Oct 10, 2024
6 checks passed
@LeFrosch LeFrosch deleted the Daniel.Brauner/download-buildifier branch October 10, 2024 11:03
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants