[#6664] Gate ExternalWorkspaceDataProvider on bzlmod being enabled
#6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g enabled This change enhances the BlazeInfo collection to also collect the value of `startlark-semantics`. This will tell if any Starlark specific flags have been flipped from default. The flag we care about it `bzlmod`. Use this info key contents to gate running of `ExternalWorkspaceDataProvider` (in addition to bazel version).
github-actions
bot
added
product: CLion
tpasternak
approved these changes
Sep 3, 2024
There was a problem hiding this comment.
One thing to note here is:
it will always run two blaze info commands back to back since making it run only one requires whitelisting all the used info flags in one command. If that can be a problem I can change it back to a whitelist but that has the risk of not pulling all the used flags.
Yeah, let's condense it into a single bazel info call, but it's definitely not a blocker
github-actions
bot
removed
the
awaiting-review
mtoader
deleted the
mtoader/gate-external-workspace-data-provider-on-bzlmod-being-enabled
branch
mtoader
added a commit
to mtoader/intellij
that referenced
this pull request
Sep 5, 2024
In PR bazelbuild#6711 i added two back to back bazel info calls. This PR collapsed those calls into one.
3 tasks
mtoader
added a commit
to mtoader/intellij
that referenced
this pull request
Sep 5, 2024
In PR bazelbuild#6711 i added two back to back bazel info calls. This PR collapsed those calls into one.
mtoader
added a commit
to mtoader/intellij
that referenced
this pull request
Sep 5, 2024
In PR bazelbuild#6711 i added two back to back bazel info calls. This PR collapsed those calls into one.
mtoader
added a commit
to mtoader/intellij
that referenced
this pull request
Sep 5, 2024
In PR bazelbuild#6711 i added two back to back bazel info calls. This PR collapsed those calls into one.
tpasternak
pushed a commit
that referenced
this pull request
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Discussion thread for this change
Issue number:
6664(#6664)Issue number:
6703(#6703)Description of this change
This change enhances the BlazeInfo collection to also collect the value of
startlark-semantics. This will tell if any Starlark specific flags have been flipped from default. The flag we care about itbzlmod.Use this info key contents to gate running of
ExternalWorkspaceDataProvider(in addition to bazel version).One thing to note here is:
it will always run two
blaze infocommands back to back since making it run only one requires whitelisting all the used info flags in one command. If that can be a problem I can change it back to a whitelist but that has the risk of not pulling all the used flags.