-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix unrecognized options by bazel mod command #6756
Conversation
CC @mtoader |
The right thing here is more complicated unfortunately since what is really needed is something similar to how This is ok for now but it will break in different ways too, e.g. adding |
Yes I thought that this might be the case. Tbh, not really sure how the bazel mod stuff works. But if it is okay with you I would like to merge this for now to fix sync. |
I'm ok with it. I have to add a notifier anyway to let people know that the plus flag should be set for proper completion to work anyway. I'll recommend them set it in the |
I also don't have write/review access here so I can't help further unfortunately |
@agluszak @tpasternak I think the semantics of |
Sorry, my responses might be delayed until the end of next week. Sure, providing bazelrc-like inheritance would be nice, however it might require extra maintenance to make sure we agree with bazel on that. It could also be done for free just with --bazelrc CLI option, it would be even a low hanging fruit in the old plugin, to provide 'bazelrc` section that would create a bazelrc file on the fly. It could replace all other sections and perform better But speaking about this particular problem, it seems like the |
Yea. That was my thinking also. I opened a ticket to think about this in the new plugin (now might be a good time to update section semantics if this is what it would be needed and since I'm adding blazerc support there it would be easier too). |
(cherry picked from commit 02ad803)
Build flags defined in the project view are forwarded to
bazel mod
which breaks sync, since--define
is not a known option for the mod command.Not sure if excluding build flags from the mod command is the right way to go. But fixes the sync.