Fix view_project_root with overlapping directories #6767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `view_project_root: true` and there are overlapping directories, for example: The repo contains these directories: - foo - foo/bar - foo/baz And .bazelproject is: ``` view_project_root: true directories: foo foo/bar ``` Then, `foo/baz` will incorrectly be excluded. This is unexpected because it's contained under the `foo` directory. This commit fixes the behavior, so that files are not excluded if they are under any root directory. Change-Id: Icd218fa33a79a7c74986255cce7788ea6b4d586d
github-actions
bot
added
product: CLion
tpasternak
approved these changes
Sep 24, 2024
github-actions
bot
removed
the
awaiting-review
|
Thank you @jdai8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.
Discussion thread for this change
Issue number:
<please reference the issue number or url here>Description of this change
When
view_project_root: trueand there are overlapping directories, for example:The repo contains these directories:
And .bazelproject is:
Then,
foo/bazwill incorrectly be excluded. This is unexpected because it's contained under thefoodirectory.This commit fixes the behavior, so that files are not excluded if they are under any root directory.