Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6807] Make failures bazel mod dump_repo_mapping failures silent #6809

Merged

Conversation

mtoader
Copy link
Contributor

@mtoader mtoader commented Sep 27, 2024

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Discussion thread for this change

Issue number: #6807

Description of this change

This makes any failure to execute bazel mod dump_repo_mapping a console warning instead of breaking the sync.

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Sep 27, 2024
@mtoader mtoader force-pushed the mtoader/make-bazel-mod-failures-soft branch 2 times, most recently from a351d2a to 943ca4d Compare September 27, 2024 22:37
@mtoader mtoader force-pushed the mtoader/make-bazel-mod-failures-soft branch from 943ca4d to 13e1382 Compare September 27, 2024 22:48
@tpasternak tpasternak merged commit e874bd1 into bazelbuild:master Sep 30, 2024
6 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Sep 30, 2024
@mtoader mtoader deleted the mtoader/make-bazel-mod-failures-soft branch September 30, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants