chore: copy some aspect files to the client side to prepare for templating #6842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xuansontrinh
requested review from
mai93,
tpasternak and
agluszak
as code owners
github-actions
bot
added
product: CLion
xuansontrinh
force-pushed
the
son/copy_java_info_to_project_side
branch
from
a47f340
to
4084549
Compare
xuansontrinh
force-pushed
the
son/copy_java_info_to_project_side
branch
from
4084549
to
0907230
Compare
…to_project_side # Conflicts: # aspect/intellij_info_impl.bzl
xuansontrinh
force-pushed
the
son/copy_java_info_to_project_side
branch
from
ea0279c
to
10b801d
Compare
xuansontrinh
force-pushed
the
son/copy_java_info_to_project_side
branch
from
ba77815
to
4d012c9
Compare
xuansontrinh
force-pushed
the
son/copy_java_info_to_project_side
branch
from
4d012c9
to
8d6b4c4
Compare
…to_project_side # Conflicts: # aspect/intellij_info_impl.bzl
|
The test is most likely false positive. Let's disable it for now, so @xuansontrinh can move forward and I (or someone else) will take care of the test |
tpasternak
approved these changes
Oct 9, 2024
github-actions
bot
removed
the
awaiting-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of this change
The purpose of this PR is to ready the plugin for templating some aspect files, e.g.
java_info.bzl.This is just an intermediate step and the next change may considerably change what is put here.