Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable bazel deps call. It's unused yet, and could fail #6860

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Disable bazel deps call. It's unused yet, and could fail #6860

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
644b3fe
Disable bazel deps call. It's unused yet, and could fail
tpasternak Oct 7, 2024
731469c
chore: Remove unused field 'deps'
tpasternak Oct 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions base/src/com/google/idea/blaze/base/model/ExternalWorkspaceDataProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,13 +105,11 @@ public ListenableFuture<ExternalWorkspaceData> getExternalWorkspaceData(
.getBuildSystem()
.getDefaultInvoker(project, context);

deps = BlazeModRunner.getInstance().getDeps(project, buildInvoker, context, importSettings.getBuildSystem(), blazeFlags);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove the field declaration for deps if it is not used?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but I'm going to use it in later prs, just didn't have time to finish. Required for bazel 8

externalWorkspaceData =
BlazeModRunner.getInstance()
.dumpRepoMapping(
project, buildInvoker, context, importSettings.getBuildSystem(), blazeFlags)
.get();
deps.get();
} catch (InterruptedException | ExecutionException e) {
context.handleExceptionAsWarning(
"Failed to run `blaze mod dump_repo_mapping` (completion of labels from module provided repos will be unavailable)",
Expand Down