release java_tools javac11-v2.0 #8
Comments
|
Creating rc1: |
|
Bazel upgrade is happening in bazelbuild/bazel#8498 Bazel tests pipeline started: https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/3129 |
|
The tests fail due to a circular dependency: This requires a fix in bazel and a new rc. |
|
Fix was sent in bazelbuild/bazel#8529. A new RC can be created after bazelbuild/bazel#8529 is merged in bazel. |
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this issue
May 31, 2019
Bazel 0.26 added the `jacocorunner` attribute on `java_toolchain`. Java targets now fail when using the new host java_toolchain because of a dependency cycle: ``` @bazel_tools//tools/jdk:JacocoCoverageRunner @bazel_tools//tools/jdk:current_java_toolchain @bazel_tools//tools/jdk:legacy_current_java_toolchain @bazel_tools//tools/jdk:remote_toolchain @remote_java_tools_linux//:toolchain .-> @remote_java_tools_linux//:jacoco_coverage_runner (host) | @bazel_tools//tools/jdk:current_java_toolchain (host) | @bazel_tools//tools/jdk:legacy_current_java_toolchain (host) | @bazel_tools//tools/jdk:remote_toolchain (host) | @remote_java_tools_linux//:toolchain (host) `-- @remote_java_tools_linux//:jacoco_coverage_runner (host) ``` The dependency is happening because `jacocorunner` in `java_toolchain` was declared as a `java_import` which depends on the host `java_toolchain`. The issue was not caught because we only run the java integration tests with `--java_toolchain` built at head. If we had run the tests also with `--host_java_toolchain` the issue would have been caught (see #8530). This PR does the following: * Makes `jacocorunner` attribute a `filegroup` instead of a `java_import` to avoid the dependency cycle. * Converts the type of `jacocoRunner` in `JavaToolchain` from a `TransitiveInfoCollection` to `FilesToRunProvider` to be able to retrieve the executable jar from the `filegroup`. * Adds testing with `--host_java_toolchain` of the java_tools built as head This is a blocker for the new java_tools release (bazelbuild/java_tools#8). Closes #8529. PiperOrigin-RevId: 250876908
|
Creating rc2: |
|
Testing for rc2 failed with errors like these: This happened because the java tools Buildkite pipeline was recently updated by the EngProd team to build the linux artifact on Ubuntu 18 instead of Ubuntu 14. I update the pipeline settings to build on Ubuntu 14 and created rc3: bazel commit hash: |
|
My change in the buildkite pipeline settings was not enough to build on Ubuntu 14. I sent a PR to change this setting in the pipeline yml configuration file as well (bazelbuild/continuous-integration#695) New build for RC 4: https://buildkite.com/bazel-trusted/java-tools-binaries-java/builds/113 |
|
All tests passed. Releasing RC4: |
bazel-io
pushed a commit
to bazelbuild/bazel
that referenced
this issue
Jun 3, 2019
Upgrade the java tools version in Bazel to `javac_11-v2.0`. This PR fixes reported errors of `missing input file '@remote_java_tools_darwin//:Genclass'` (e.g. bazelbuild/intellij#845). Also update the java_tools version for javac 9 and 10 that are used in tests. New java_tools releases for javac 9 and 10 were required because of new bazel API (`java_toolchain` now has an `jacocorunner` attribute). The detailed release of `javac_11-v2.0` can be found in bazelbuild/java_tools#8. The detailed release of java_tools `javac9-v2.0` and `javac10-v4.0` can be found in bazelbuild/java_tools#10. Closes #8498. PiperOrigin-RevId: 251245301
irengrig
pushed a commit
to irengrig/bazel
that referenced
this issue
Jun 18, 2019
Bazel 0.26 added the `jacocorunner` attribute on `java_toolchain`. Java targets now fail when using the new host java_toolchain because of a dependency cycle: ``` @bazel_tools//tools/jdk:JacocoCoverageRunner @bazel_tools//tools/jdk:current_java_toolchain @bazel_tools//tools/jdk:legacy_current_java_toolchain @bazel_tools//tools/jdk:remote_toolchain @remote_java_tools_linux//:toolchain .-> @remote_java_tools_linux//:jacoco_coverage_runner (host) | @bazel_tools//tools/jdk:current_java_toolchain (host) | @bazel_tools//tools/jdk:legacy_current_java_toolchain (host) | @bazel_tools//tools/jdk:remote_toolchain (host) | @remote_java_tools_linux//:toolchain (host) `-- @remote_java_tools_linux//:jacoco_coverage_runner (host) ``` The dependency is happening because `jacocorunner` in `java_toolchain` was declared as a `java_import` which depends on the host `java_toolchain`. The issue was not caught because we only run the java integration tests with `--java_toolchain` built at head. If we had run the tests also with `--host_java_toolchain` the issue would have been caught (see bazelbuild#8530). This PR does the following: * Makes `jacocorunner` attribute a `filegroup` instead of a `java_import` to avoid the dependency cycle. * Converts the type of `jacocoRunner` in `JavaToolchain` from a `TransitiveInfoCollection` to `FilesToRunProvider` to be able to retrieve the executable jar from the `filegroup`. * Adds testing with `--host_java_toolchain` of the java_tools built as head This is a blocker for the new java_tools release (bazelbuild/java_tools#8). Closes bazelbuild#8529. PiperOrigin-RevId: 250876908
irengrig
pushed a commit
to irengrig/bazel
that referenced
this issue
Jun 18, 2019
Upgrade the java tools version in Bazel to `javac_11-v2.0`. This PR fixes reported errors of `missing input file '@remote_java_tools_darwin//:Genclass'` (e.g. bazelbuild/intellij#845). Also update the java_tools version for javac 9 and 10 that are used in tests. New java_tools releases for javac 9 and 10 were required because of new bazel API (`java_toolchain` now has an `jacocorunner` attribute). The detailed release of `javac_11-v2.0` can be found in bazelbuild/java_tools#8. The detailed release of java_tools `javac9-v2.0` and `javac10-v4.0` can be found in bazelbuild/java_tools#10. Closes bazelbuild#8498. PiperOrigin-RevId: 251245301
irengrig
pushed a commit
to irengrig/bazel
that referenced
this issue
Jul 15, 2019
Bazel 0.26 added the `jacocorunner` attribute on `java_toolchain`. Java targets now fail when using the new host java_toolchain because of a dependency cycle: ``` @bazel_tools//tools/jdk:JacocoCoverageRunner @bazel_tools//tools/jdk:current_java_toolchain @bazel_tools//tools/jdk:legacy_current_java_toolchain @bazel_tools//tools/jdk:remote_toolchain @remote_java_tools_linux//:toolchain .-> @remote_java_tools_linux//:jacoco_coverage_runner (host) | @bazel_tools//tools/jdk:current_java_toolchain (host) | @bazel_tools//tools/jdk:legacy_current_java_toolchain (host) | @bazel_tools//tools/jdk:remote_toolchain (host) | @remote_java_tools_linux//:toolchain (host) `-- @remote_java_tools_linux//:jacoco_coverage_runner (host) ``` The dependency is happening because `jacocorunner` in `java_toolchain` was declared as a `java_import` which depends on the host `java_toolchain`. The issue was not caught because we only run the java integration tests with `--java_toolchain` built at head. If we had run the tests also with `--host_java_toolchain` the issue would have been caught (see bazelbuild#8530). This PR does the following: * Makes `jacocorunner` attribute a `filegroup` instead of a `java_import` to avoid the dependency cycle. * Converts the type of `jacocoRunner` in `JavaToolchain` from a `TransitiveInfoCollection` to `FilesToRunProvider` to be able to retrieve the executable jar from the `filegroup`. * Adds testing with `--host_java_toolchain` of the java_tools built as head This is a blocker for the new java_tools release (bazelbuild/java_tools#8). Closes bazelbuild#8529. PiperOrigin-RevId: 250876908
irengrig
pushed a commit
to irengrig/bazel
that referenced
this issue
Jul 15, 2019
Upgrade the java tools version in Bazel to `javac_11-v2.0`. This PR fixes reported errors of `missing input file '@remote_java_tools_darwin//:Genclass'` (e.g. bazelbuild/intellij#845). Also update the java_tools version for javac 9 and 10 that are used in tests. New java_tools releases for javac 9 and 10 were required because of new bazel API (`java_toolchain` now has an `jacocorunner` attribute). The detailed release of `javac_11-v2.0` can be found in bazelbuild/java_tools#8. The detailed release of java_tools `javac9-v2.0` and `javac10-v4.0` can be found in bazelbuild/java_tools#10. Closes bazelbuild#8498. PiperOrigin-RevId: 251245301
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The release must contain bazelbuild/bazel#8490
This issue follows the instructions under java_tools release process.
The text was updated successfully, but these errors were encountered: