tool test: improving coverage, cleanups, minor fixes #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ola-rozenfeld
commented
Jul 2, 2023
| @@ -288,7 +288,7 @@ func (f *InputFile) apply(ac *repb.ActionResult, s *Server, execRoot string) err | |||
| if err := os.MkdirAll(filepath.Join(execRoot, filepath.Dir(f.Path)), os.ModePerm); err != nil { | |||
| return fmt.Errorf("failed to create input dir %v: %v", filepath.Dir(f.Path), err) | |||
| } | |||
| err := os.WriteFile(filepath.Join(execRoot, f.Path), nil, 0755) | |||
| err := os.WriteFile(filepath.Join(execRoot, f.Path), bytes, 0755) | |||
There was a problem hiding this comment.
That's from #473
| @@ -83,8 +86,8 @@ Platform | |||
|
|
|||
| Inputs | |||
| ====== | |||
| [Root directory digest: e23e10be0d14b5b2b1b7af32de78dea554a74df5bb22b31ae6c49583c1a8aa0e/75] | |||
| a/b/input.txt: [File digest: e3b0c44298fc1c149afbf4c8996fb92427ae41e4649b934ca495991b7852b855/0] | |||
| [Root directory digest: 1b1d5b9e3eb97866805deca901299fcdde98b5747e147f35187e12c16e120186/75] | |||
There was a problem hiding this comment.
That's from #473
| @@ -109,55 +112,98 @@ func TestTool_CheckDeterminism(t *testing.T) { | |||
| e, cleanup := fakes.NewTestEnv(t) | |||
| defer cleanup() | |||
| cmd := &command.Command{ | |||
| Args: []string{"foo bar baz"}, | |||
| Args: []string{"foo", "bar", "baz"}, | |||
There was a problem hiding this comment.
This is here (and below) in order to not provide bad examples in our unit tests. E.g. "echo hello world" would not work as a single string; it needs to be split up.
|
|
||
| client := &Client{GrpcClient: e.Client.GrpcClient} | ||
| if err := client.CheckDeterminism(context.Background(), acDg.String(), "", 2); err != nil { | ||
| t.Errorf("CheckDeterminism returned an error: %v", err) | ||
| } | ||
| // Now execute again with changed inputs. |
There was a problem hiding this comment.
This comment was a result of copy-paste; inputs do not actually change, only output does.
|
Preview of the Node Properties support change: ola-rozenfeld#1 |
mrahs
approved these changes
Jul 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes #473 because I couldn't figure out how to send a PR chain, sorry!
fakes.InputFilewhenever appropriateExecuteAction*tests to not depend on implementation of the fake, and instead to mimics the user journey (downloading the inputs locally, then changing them).What I was actually doing is fixing #460, but that PR got a bit too big with unrelated fixes and cleanups, so I decided to split these out.
Thank you!