Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write R8 proguard mappings to a file #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Write R8 proguard mappings to a file #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions rules/android_binary_internal/r8.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,23 +74,43 @@ def process_r8(ctx, jvm_ctx, packaged_resources_ctx, build_info_ctx, **_unused_c
android_jar = get_android_sdk(ctx).android_jar
proguard_specs = proguard.get_proguard_specs(ctx, packaged_resources_ctx.resource_proguard_config)
min_sdk_version = getattr(ctx.attr, "min_sdk_version", None)
is_resource_shrinking_enabled = _resources.is_resource_shrinking_enabled(
ctx.attr.shrink_resources,
ctx.fragments.android.use_android_resource_shrinking,
)
generate_proguard_map = (
ctx.attr.proguard_generate_mapping or is_resource_shrinking_enabled
)
proguard_mappings_output_file = None
if generate_proguard_map:
proguard_mappings_output_file = ctx.actions.declare_file(ctx.label.name + "_proguard.txt")

inputs = []
outputs = []

args = ctx.actions.args()
args.add("--release")
if min_sdk_version:
args.add("--min-api", min_sdk_version)
if proguard_mappings_output_file:
args.add("--pg-map-output", proguard_mappings_output_file)
outputs.append(proguard_mappings_output_file)
args.add("--output", dexes_zip)
outputs.append(dexes_zip)
args.add_all(proguard_specs, before_each = "--pg-conf")
inputs.extend(proguard_specs)
args.add("--lib", android_jar)
inputs.append(android_jar)
args.add(deploy_jar) # jar to optimize + desugar + dex
inputs.append(deploy_jar)

java.run(
ctx = ctx,
host_javabase = common.get_host_javabase(ctx),
executable = get_android_toolchain(ctx).r8.files_to_run,
arguments = [args],
inputs = [android_jar, deploy_jar] + proguard_specs,
outputs = [dexes_zip],
inputs = inputs,
outputs = outputs,
mnemonic = "AndroidR8",
jvm_flags = ["-Xmx8G"],
progress_message = "R8 Optimizing, Desugaring, and Dexing %{label}",
Expand All @@ -108,6 +128,7 @@ def process_r8(ctx, jvm_ctx, packaged_resources_ctx, build_info_ctx, **_unused_c
name = "r8_ctx",
value = struct(
final_classes_dex_zip = dexes_zip,
proguard_mappings_output_file = proguard_mappings_output_file,
providers = [android_dex_info],
),
)
Expand Down