[SNAP FORK][UPSTREAMED] Fix idl tool #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mauriciogg
commented
Jan 17, 2023
mauriciogg
commented
- Using deploy jar, since tool is exectuted as java -jar. Otherwise artifact is the sh runner file.
- Create a unique directory for the tmp directory for idl. This directory is removed on each execution so passing the runfileles dir will delete all inputs. seel https://livegrep.sc-corp.net/view/Snapchat/bazel/src/main/java/com/google/devtools/build/lib/rules/android/AndroidIdlHelper.java#L348
- Using deploy jar, since tool is exectuted as java -jar. Otherwise artifact is the sh runner file. - Create a unique directory for the tmp directory for idl. This directory is removed on each execution so passing the runfileles dir will delete all inputs. seel https://livegrep.sc-corp.net/view/Snapchat/bazel/src/main/java/com/google/devtools/build/lib/rules/android/AndroidIdlHelper.java#L348
ted-xie
pushed a commit
to ted-xie/rules_android
that referenced
this pull request
Jul 16, 2024
…build#61) This enables using `--extra_toolchains` on specific platforms, which is helpful when building a monorepo that has platforms without the Android SDK/NDK available. Without this, it's impossible to use these rules if you're planning in a system where the NDK is unavailable (or not installed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.