WIP: insert pre- and post- actions in ios_xctestrun_runner
#2649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsky
changed the title
ios_xctestrun_runneios_xctestrun_runner
luispadron
reviewed
Feb 11, 2025
luispadron
reviewed
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Iterating on this out in the open. It's a proof of concept, but it does work. I'm not married to any aspect of this API, the fact that hooks have access to all environment variables the test runner does, nor the lack of a live log-parser hook in this implementation. I recommend maintainers be ruthless and specific in what they want out of this change.