Skip to content

Commit

Permalink
Change image rule to copy config instead of symlink
Browse files Browse the repository at this point in the history
The image rule in container/image.bzl was symlinking the config file for
strutcture tests. This caused remote execution with
--remote_download_minimal to fail as symlinks aren't yet supported.
  • Loading branch information
exoson committed Jul 22, 2020
1 parent 204e77b commit 2a280af
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions container/image.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -506,12 +506,11 @@ def _impl(
)
_assemble_image_digest(ctx, name, container_parts, output_tarball, output_digest)

# Symlink config file for usage in structure tests
ln_path = config_file.path.split("/")[-1]
# Copy config file for usage in structure tests
ctx.actions.run_shell(
outputs = [output_config],
inputs = [config_file],
command = "ln -s %s %s" % (ln_path, output_config.path),
command = "cp %s %s" % (config_file.path, output_config.path),
)

runfiles = ctx.runfiles(
Expand Down

0 comments on commit 2a280af

Please sign in to comment.