Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate python scripts to python3 #1203

Closed
wants to merge 10 commits into from
Closed

Conversation

smukherj1
Copy link
Collaborator

For the security_check.py, had to use a Go binary to generate YAML from JSON because the pip rules in rules_python seem to want to keep downloading the python2 YAML library.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smukherj1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

nlopezgi added a commit that referenced this pull request Oct 16, 2019
* testing changes to platforms

* fixes

* fix py2->py3 incompat

* fix more py
@nlopezgi
Copy link
Contributor

nlopezgi commented Oct 16, 2019

Closed in favor of #1205

@nlopezgi nlopezgi closed this Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants