Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce output_group for pusher executable #1685

Merged
merged 1 commit into from
Dec 22, 2020
Merged

Introduce output_group for pusher executable #1685

merged 1 commit into from
Dec 22, 2020

Conversation

alexeagle
Copy link
Collaborator

This allows the pusher to be referenced as a label without including all the default outputs including the .digest file

Fixes #1684

Also use the user-provided value for the (undocumented) "extension" parameter if one is set.

Fixes #1683

Introduce output_group for pusher executable
f26e171 
This allows the pusher to be referenced as a label without including all the default outputs including the .digest file

Fixes bazelbuild#1684

Also use the user-provided value for the (undocumented) "extension" parameter if one is set.

Fixes bazelbuild#1683
@google-cla google-cla bot added the cla: yes label Nov 23, 2020
@alexeagle
Copy link
Collaborator Author

ping @smukherj1 :)

@smukherj1
Copy link
Collaborator

ping @smukherj1 :)

Apologies for the massive delay. We'll get to this within a week

@eytankidron
Copy link
Collaborator

/gcbrun

@eytankidron
Copy link
Collaborator

Dumb question: when you call
extension = kwargs.pop("extension", ...)
that pops "extension" out of kwargs. Is it what you want to do given that you then pass **kwargs as the last arg to _container_push?
Would kwargs.get be better?

@alexeagle
Copy link
Collaborator Author

@eytankidron yes it needs pop so that we don't pass the extension attribute twice.

ping again on getting this in?

@eytankidron
Copy link
Collaborator

/gcbrun

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alexeagle, eytankidron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eytankidron eytankidron merged commit 7da0de3 into bazelbuild:master Dec 22, 2020
@alexeagle alexeagle deleted the container_push branch December 23, 2020 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eytankidron eytankidron eytankidron approved these changes

@DaveGay DaveGay Awaiting requested review from DaveGay

@smukherj1 smukherj1 Awaiting requested review from smukherj1 smukherj1 is a code owner

Assignees

@eytankidron eytankidron

Labels
approved cla: yes lgtm size/XS
Projects
None yet
Milestone
No milestone
4 participants
@alexeagle @smukherj1 @eytankidron @k8s-ci-robot