Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRAFT (RFC): Allow images to have abi representation #2062

Closed
wants to merge 1 commit into from
Closed

DRAFT (RFC): Allow images to have abi representation #2062

wants to merge 1 commit into from

Conversation

UebelAndre
Copy link
Contributor

@UebelAndre UebelAndre commented Apr 19, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: closes #2063

What is the new behavior?

This pull-request is a draft aimed at exploring requirements for bazelbuild/platforms#38. A similar change was proposed to make rules_rust ABI aware (bazelbuild/rules_rust#1270) with the desire to be able to build targets for the x86_64-unknown-linux-musl platform and as a dependency to an Alpine image (which uses musl).

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@UebelAndre UebelAndre changed the title Allow images to have abi representation DRAFT (RFC): Allow images to have abi representation Apr 19, 2022
@github-actions
Copy link

This Pull Request has been automatically marked as stale because it has not had any activity for 180 days. It will be closed if no further activity occurs in 30 days.
Collaborators can add an assignee to keep this open indefinitely. Thanks for your contributions to rules_docker!

@github-actions github-actions bot added the Can Close? Will close in 30 days unless there is a comment indicating why not label Oct 17, 2022
@github-actions
Copy link

This PR was automatically closed because it went 30 days without a reply since it was labeled "Can Close?"

@github-actions github-actions bot closed this Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Can Close? Will close in 30 days unless there is a comment indicating why not
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ABI support to docker images
1 participant