(DUPLICATE) Bump the container-structure-test tool to v1.11.0 #2072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old v1.9.1 version was segfaulting on Monteray (Mac OS 12.3). I've confirmed that the v1.11.0 version works correctly. The (closed) upstream bug is GoogleContainerTools/container-structure-test#286
jcourteau
requested review from
smukherj1,
alexeagle,
pcj and
gravypod
as code owners
|
This may be sufficient to re-enable these - #1952 ? |
|
This probably fixes #2012 |
|
This looks like a duplicate of #2013 |
Good catch! I missed that in my initial checking of issues. Closing this PR, and will add notes to the other one. |
jcourteau
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old v1.9.1 version was segfaulting on Monteray (Mac OS 12.3). I've
confirmed that the v1.11.0 version works correctly.
The (closed) upstream bug is GoogleContainerTools/container-structure-test#286
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
container-structure-test)What is the current behavior?
when using
container_test()on Mac OS X Monterey, on an M1 Pro, I get a segmentation fault:Segmentation fault: 11 ../structure_test_darwin/file/downloaded version
What is the new behavior?
container_test()now successfully invokes the toolDoes this PR introduce a breaking change?
Other information