[layer_tools/generate_args_for_image] Inject extra argument to the given callback #2088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ven callback
When using a transition we need to give a callback function
to compute a path specific for this transition.
This information is not available from the context (ctx)
and the given file.
We need to have a way to inject this extra information.
Example with an architecture specific transition:
```starlark
def _to_arch_path(ctx, f, arch = None):
"""Returns the architecture specific path of the given file f."""
return paths.join(
paths.dirname(f.short_path),
arch,
paths.basename(f.short_path),
)
def _xxx_impl(ctx):
...
# image is an attribute with a 1:2+ transition
for image_target in ctx.attr.image:
image = ... [ImageInfo].container_parts
arch = ...
...
img_args, img_inputs = generate_args_for_image(
ctx, image, _to_arch_path, arch = arch,
)
...
symlinks.update({
_to_arch_path(ctx, i, arch = arch): i
for i in img_inputs
})
...
runfiles = ctx.runfiles(
files = ...
symlinks = symlinks
)
```
ghost
requested review from
gravypod,
linzhp,
pcj,
smukherj1 and
uhthomas
as code owners
St0rmingBr4in
pushed a commit
to St0rmingBr4in/rules_docker
that referenced
this pull request
Oct 17, 2022
…ven callback (bazelbuild#2088) When using a transition we need to give a callback function to compute a path specific for this transition. This information is not available from the context (ctx) and the given file. We need to have a way to inject this extra information. Example with an architecture specific transition: ```starlark def _to_arch_path(ctx, f, arch = None): """Returns the architecture specific path of the given file f.""" return paths.join( paths.dirname(f.short_path), arch, paths.basename(f.short_path), ) def _xxx_impl(ctx): ... # image is an attribute with a 1:2+ transition for image_target in ctx.attr.image: image = ... [ImageInfo].container_parts arch = ... ... img_args, img_inputs = generate_args_for_image( ctx, image, _to_arch_path, arch = arch, ) ... symlinks.update({ _to_arch_path(ctx, i, arch = arch): i for i in img_inputs }) ... runfiles = ctx.runfiles( files = ... symlinks = symlinks ) ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
When using a transition we need to give a callback function to compute a path specific for this transition.
This information is not available from the context (
ctx) and the given file.We need to have a way to inject this extra information.
Example with an architecture specific transition:
Does this PR introduce a breaking change?