Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick correct compiler for CMAKE_CXX_COMPILER #1030

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

ozanarmagan
Copy link

Fix to solve the problem of picking gcc instead of g++ and clang instead of clang++ by a simple function.

@google-cla
Copy link

google-cla bot commented Mar 16, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ozanarmagan
Copy link
Author

Hi @jsharpe, this little trick can fix #931

@jheaff1
Copy link
Collaborator

jheaff1 commented Mar 22, 2023

Would this also work when cross compiling, eg with a compiler named “arm-none-eabi-gcc”?

@jheaff1
Copy link
Collaborator

jheaff1 commented Mar 22, 2023

Does this mean that pure C libraries (eg openssl and libcurl) will be built with g++ rather than gcc and therefore will unnecessarily link to libstdc++? If so, this change should be optional via a rule attribute

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants