Move the test library rule to be go_test internal actions #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes a rule from the visible graph that the user does not really want to know about, and also gives the go_test rule more power to control the compilation of it's library
jayconrod
approved these changes
Jan 23, 2018
sluongng
added a commit
to sluongng/rules_go
that referenced
this pull request
Jun 28, 2022
`_testmain_library_to_source` was introduced in 1c4f6fd and last usage of this resolver was in 56e5592. ``` > git log -S'_testmain_library_to_source' --oneline 56e5592 Move the test library rule to be go_test internal actions (bazelbuild#1267) 9031d58 Add GoContext (bazelbuild#1140) 1c4f6fd Fix aspect based proto builds (bazelbuild#1131) ``` Let's remove the unused resolver and replace the documentation with the resolver that is actually being used.
linzhp
pushed a commit
that referenced
this pull request
Jul 17, 2022
`_testmain_library_to_source` was introduced in 1c4f6fd and last usage of this resolver was in 56e5592. ``` > git log -S'_testmain_library_to_source' --oneline 56e5592 Move the test library rule to be go_test internal actions (#1267) 9031d58 Add GoContext (#1140) 1c4f6fd Fix aspect based proto builds (#1131) ``` Let's remove the unused resolver and replace the documentation with the resolver that is actually being used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes a rule from the visible graph that the user does not really want to
know about, and also gives the go_test rule more power to control the
compilation of it's library