Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default_java_toolchain.bzl to match Bazel@head version. #58

Merged

Conversation

comius
Copy link
Collaborator

@comius comius commented Jul 20, 2022

Fixes #57

@comius comius requested a review from cushon July 20, 2022 16:04
@comius comius requested review from lberki, c-mita, oquenchil, katre and a team as code owners July 20, 2022 16:04
katre
katre previously approved these changes Jul 20, 2022
@jpsim
Copy link
Contributor

jpsim commented Jul 20, 2022

This appears to work in my local testing in the project that surfaced the error I described in #57. I'll continue to do more in-depth testing but so far so good.

Thanks for the super fast response @comius!

@jpsim
Copy link
Contributor

jpsim commented Jul 20, 2022

Actually I am seeing some "indirect dependency" errors in my project now, similar to the errors that have failed the CI jobs on this PR:

bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bazel_tools/src/main/protobuf/_javac/worker_protocol_proto/libworker_protocol_proto-speed_tmp/com/google/devtools/build/lib/worker/WorkerProtocol.java:9: error: [strict] Using type com.google.protobuf.ExtensionRegistryLite from an indirect dependency (TOOL_INFO: "@com_google_protobuf//java/core:lite_runtime_only"). See command below **
      com.google.protobuf.ExtensionRegistryLite registry) {
                         ^
bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bazel_tools/src/main/protobuf/_javac/worker_protocol_proto/libworker_protocol_proto-speed_tmp/com/google/devtools/build/lib/worker/WorkerProtocol.java:13: error: [strict] Using type com.google.protobuf.ExtensionRegistry from an indirect dependency (TOOL_INFO: "@com_google_protobuf//java/core"). See command below **
      com.google.protobuf.ExtensionRegistry registry) {
                         ^
bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/bazel_tools/src/main/protobuf/_javac/worker_protocol_proto/libworker_protocol_proto-speed_tmp/com/google/devtools/build/lib/worker/WorkerProtocol.java:32: error: [strict] Using type java.lang.String from an indirect dependency (TOOL_INFO: "/private/var/tmp/_bazel_jsimard/7140f038a5c13b01a171c93151a000da/execroot/envoy_mobile/bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_java/toolchains/platformclasspath.jar").
    java.lang.String getPath();
             ^
 ** Please add the following dependencies: 
  @com_google_protobuf//java/core @com_google_protobuf//java/core:lite_runtime_only to @bazel_tools//src/main/protobuf:worker_protocol_proto 
 ** You can use the following buildozer command: 
buildozer 'add deps @com_google_protobuf//java/core @com_google_protobuf//java/core:lite_runtime_only' @bazel_tools//src/main/protobuf:worker_protocol_proto 

@jpsim
Copy link
Contributor

jpsim commented Jul 20, 2022

And there appears to be a second error as well regarding runtime_toolchain_type that I also see with bazel 6.0.0-pre.20220608.2 only with this branch:

No matching toolchains found for types @bazel_tools//tools/jdk:runtime_toolchain_type.

@comius comius force-pushed the update-default_java_toolchain branch from f6d843a to 2b22c47 Compare July 21, 2022 07:52
@copybara-service copybara-service bot merged commit b32e72a into bazelbuild:master Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incompatible with latest bazel rolling release
3 participants