-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple Kotlin compiler from Kotlin rules #899
base: master
Are you sure you want to change the base?
Conversation
@@ -11,10 +11,6 @@ | |||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | |||
# See the License for the specific language governing permissions and | |||
# limitations under the License. | |||
# dev_io_bazel_rules_kotlin | |||
load("@{{.KotlinRulesRepository}}//kotlin:jvm.bzl", "kt_jvm_import") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to provide the old targets with a deprecated warning for at least a version.
The docs have encouraged folks to this repository for a while, so the transition process should be deprecate then remove.
22b80d6
to
6e1ecc3
Compare
6e1ecc3
to
1091cfc
Compare
I see 2 options, I think are slightly better than current state (
Or we could also go forward with current state - export such Kotlin compiler repo and remove the deprecated targets in one of the future version of Kotlin compilers? WDYT? |
apologies, the holidays became very hectic.
Over all, folk's relying on the compiler repo is actually a fairly annoying problem. For example, a lot of kotlin deps bring the jars as part of the transitive closure -- this leads to duplicated jars on the classpath, etc. etc. Ideally, we'd move to just using the maven jars, which helps solve the problem. Let's go with 1 -- @Bencodes @nkoroste: can you verify that switching to |
Any update on this? |
Move Kotlin specific targets (like
kt_jvm_import
) fromBUILD.com_github_jetbrains_kotlin
to//kotlin/compiler
.This will make it possible to release
kotlin-compiler
module onbazel-central-registry
without depending onrules_kotlin
. The release will contain the new formBUILD.com_github_jetbrains_kotlin
which doesn't depend onrules_kotlin
.RELNOTES[INC]: This breaks users that depend on
@com_github_jetbrains_kotlin//:*
targets. The same targets can be found under@io_bazel_rules_kotlin//kotlin/compiler:*
.It's not possible to add an
alias
to@com_github_jetbrains_kotlin
repository, becuase it would already create a dependency onrules_kotlin
repository in the bzlmod world.Technically it's possible to release 2 bzlmod modules that have a circular dependency. But this might create some unexpected problems. It addition it would be harder to convince
com_github_jetbrains_kotlin
owners to depend onrules_kotlin
.Works toward: #660