-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example of how to depend one pkg_deb .changes file #484
Conversation
- Add tests for that - Improve the example about finding output file paths to show how to get the implicit outputs like the changes file. Fixes bazelbuild#477
thanks for this @aiuto i have tested it and, as suggested, using |
I will find time to review this today or Friday. |
@phlax Was the example clear enough? |
yep. also, happy to relate use... first, i tried to just use the this gave me the files i wanted, but it also added unwanted so i then added a the only mistake i initially made was in thinking that it required a hope this helps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation updates are very useful, but I don't think we've ever quite come to a consensus on what should be in DefaultInfo
. See the large comment for a starter discussion. on that.
I think what you have specified here is the right thing to do, but I am not completely sold on it. The code looks good modulo the below small suggestions in the test code.
@nacl If you could do a quick review again, I would like to get this in for the example, as it appears relevant to bazelbuild/bazel#7977 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please update/reword the commit message to indicate what actually is happening here -- just a documentation/examples update.
get the implicit outputs like the changes file.
Fixes #477
cc/ @phlax